michael-s-molina commented on PR #36368: URL: https://github.com/apache/superset/pull/36368#issuecomment-3790544397
This is looking great! For now, I’ve just reviewed the PR description since you mentioned you’re still making changes to the code. - It might be worth considering renaming the variable `is_abortable` (in the state diagram/code) to `aborting`. As it stands, having a task in progress with `is_abortable = False` could give the impression that the task cannot be aborted. - I noticed you added the new tables to the PR description, which is really helpful. Could we also include a section outlining the new APIs? - You mentioned that GTF falls back to polling if a Redis operation fails. When exactly is this failed operation processed, given that polling won’t be enabled in deployments using Redis? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
