ionik0 commented on PR #37304: URL: https://github.com/apache/superset/pull/37304#issuecomment-3791945485
> I approved the CI checks to run. I'm surprised to see all the `# type: ignore[attr-defined]` in files that seem unrelated to this, that feels to me like it is outside the scope of this PR? Thanks for pointing that out, and apologies for the noise. Those # type: ignore[attr-defined] changes were not part of the intended scope of this PR — they were introduced when I ran the pre-commit/mypy checks locally, which ended up touching some unrelated files. I agree this makes the PR harder to review. I can revert those unrelated changes and keep this PR strictly focused on the original issue, or alternatively split them into a separate PR if that’s preferred. Please let me know what you’d like me to do, and sir...if its possible can you please guide me ...because i tried a lot and only 1 check is failing every time and I am unable to fix it 😔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
