bito-code-review[bot] commented on PR #37360:
URL: https://github.com/apache/superset/pull/37360#issuecomment-3792103258
<!-- Bito Reply -->
Yes, adding a functional test for `getUrl` after configuration would improve
test coverage and match the pattern for other methods. It ensures the
delegation to the instance works correctly with appRoot prefixing.
**superset-frontend/packages/superset-ui-core/test/connection/SupersetClient.test.ts**
```
SupersetClient.configure({ appRoot: '/app' });
const url = SupersetClient.getUrl({ endpoint: '/some/path' });
expect(url).toBe('/app/some/path');
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
