sfirke commented on PR #37403: URL: https://github.com/apache/superset/pull/37403#issuecomment-3792381937
> Does this need to be made dynamic (with a substituted X/Y string in the t() function) depending on whether it's horizontal/vertical? This is a good question, the names of the controls are confusing when the chart is horizontally-rotated. But that would be a bigger thing, we would need to update all of the controls where it says Y Axis Title, etc. Would they all flip together when the horizontal checkbox is clicked? Anyway, I think that's a separate matter. > Also, I note it says in the control it's not recommended to use this control in bar charts... should we just ignore/hide the control in this case? My quick take is that there are legitimate uses for it and if it's commonly *mis*used, that's a bad choice by the author, not the fault of the tool that makes it possible. I think Superset's better if we keep this control. I was just using it for a bar chart showing average customer satisfaction by category. The customer sat rating is on a scale of 1-5, so since 1 is the lowest possible value, I truncated the y-axis to start at 1. Here's a better example, showing average golf scores. Since that scale doesn't begin at 0 it feels wrong to start the y-axis there: <img width="596" height="371" alt="1lws2d7gmzh81" src="https://github.com/user-attachments/assets/0ee65346-9cb0-42ab-bb96-7c18fe6fed7e"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
