betodealmeida commented on issue #35414:
URL: https://github.com/apache/superset/issues/35414#issuecomment-3792899617
I asked Claude Code about upgrading:
⏺ Based on the breaking changes between v27.15.2 and v27.29.0, here's
what's relevant to this file:
Likely Safe (no impact)
- The file doesn't use qualify_table, unalias_group_by, lineage, or the
merge builder — so those API changes don't apply.
- The Snowflake type annotation changes are irrelevant unless the
optimize() method is used on Snowflake queries and downstream code inspects
inferred types.
Potential Behavioral Changes
1. Optimizer simplification fixes (lines 723-733) — The optimize() method
calls pushdown_predicates. Several simplification fixes could change the output:
- simplify_parens no longer removes negated parens (#6194)
- Double negation only simplified for BOOLEAN expressions (#6151)
- AND with NULL no longer simplified away (#6148)
- x XOR x no longer simplified due to NULL semantics (#6115)
2. Parser: VALUES with ORDER BY/LIMIT/OFFSET (#6094) — Could change how
queries with VALUES clauses are parsed, affecting
_extract_tables_from_statement or is_mutating.
3. Parser: DELETE with USING (#6072) — Could affect how DELETE statements
are parsed, relevant to is_mutating() (line 649: checks for exp.Delete).
4. ClickHouse tuple parsing (#5920) — Could change how ClickHouse queries
parse (line 66-67: maps to Dialects.CLICKHOUSE).
5. Hive/Spark CHANGE COLUMN (#6004) — May change how ALTER statements
parse in Hive/Spark dialects (lines 83, 108).
6. DuckDB changes — REGEXP_REPLACE with 'g' option (#6174), timestamp
literals in datediff (#6086), ~ operator (#6017) could change generated SQL for
DuckDB (line 75).
Bottom Line
No import errors or API breakage will occur in this file. The risks are
behavioral: the optimize() method may produce slightly different SQL due to
simplification fixes, and certain edge-case queries in
ClickHouse/DuckDB/Hive/Spark may parse or generate differently. If
Superset has tests covering these dialects, running them after the upgrade
should surface any issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
