massucattoj opened a new pull request, #37409: URL: https://github.com/apache/superset/pull/37409
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY Fixes styling issues on the Themes page Actions column: 1. Icon size mismatch: Action icons were 14x14px while Dashboard/Charts pages use 16x16px. Added iconSize="l" to ActionsBar component. 2. Missing tooltips: The tooltip prop was being destructured in ActionsBar but never passed to ActionButton, causing tooltips to not render. Now explicitly passing tooltip={tooltip}. 3. Tooltip text updates: Updated tooltip labels for clarity: - "Set local theme for testing" - "Edit" / "Export" / "Delete" - "Set as default light theme" / "Set as default dark theme" - "Clear default light theme" / "Clear default dark theme" - Tag tooltips: "This is the default light theme" / "This is the default dark theme" ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF BEFORE: - The `tooltips` were not showing. AFTER: - Every icon has it own `tooltip` and the correct size. <img width="1032" height="443" alt="Screenshot 2026-01-23 at 20 11 28" src="https://github.com/user-attachments/assets/f62c422d-c6d7-46a0-9707-6e77f35d27ac"; /> ### TESTING INSTRUCTIONS 1. Navigate to Settings → Themes page 2. Verify action icons in the Actions column are the same size as Dashboard/Charts pages (16x16) 3. Hover over each action icon and verify tooltips appear: - ⚡ "Set local theme for testing" - ✏️ "Edit" - ⬆️ "Export" - ☀️ "Set as default light theme" - 🌙 "Set as default dark theme" - 🗑️ "Delete" 4. Set a theme as default light/dark and verify: - Action tooltip changes to "Clear default light/dark theme" - Tag tooltip in Name column shows "This is the default light/dark theme" ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
