bito-code-review[bot] commented on code in PR #37411:
URL: https://github.com/apache/superset/pull/37411#discussion_r2723608644
##########
superset/sql_lab.py:
##########
@@ -411,6 +412,13 @@ def execute_sql_statements( # noqa: C901
):
raise SupersetDisallowedSQLFunctionException(disallowed_functions)
+ disallowed_tables = app.config["DISALLOWED_SQL_TABLES"].get(
+ db_engine_spec.engine,
+ set(),
+ )
+ if disallowed_tables and
parsed_script.check_tables_present(disallowed_tables):
+ raise SupersetDisallowedSQLTableException(disallowed_tables)
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Inconsistent disallowed tables error reporting</b></div>
<div id="fix">
The error message currently lists all configured disallowed tables, but
should only show the ones actually present in the query. This matches the
behavior in SQLExecutor and provides more precise feedback to users.
</div>
</div>
<small><i>Code Review Run #1ff438</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
