YousufFFFF commented on code in PR #36792:
URL: https://github.com/apache/superset/pull/36792#discussion_r2723897080
##########
superset/commands/database/uploaders/base.py:
##########
@@ -159,6 +159,13 @@ def run(self) -> None:
if not self._model:
return
+ # Treat empty or frontend-sent "undefined" schema as no schema
+ if not self._schema or self._schema == "undefined":
+ logger.warning(
+ "CSV UPLOAD: schema was empty or undefined, using database
default"
+ )
+ self._schema = None
Review Comment:
Good point. Superset already normalizes frontend-sent "undefined"/"null"
values using `parse_js_uri_path_item`. I’ve updated the code to reuse this
utility with `eval_undefined=True` so schema handling stays consistent with
other parts of the codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
