amaannawab923 commented on code in PR #36881:
URL: https://github.com/apache/superset/pull/36881#discussion_r2724539209
##########
superset-frontend/plugins/plugin-chart-ag-grid-table/src/AgGridTable/index.tsx:
##########
@@ -593,11 +593,7 @@ const AgGridDataTable: FunctionComponent<AgGridTableProps>
= memo(
{serverPagination && (
<Pagination
currentPage={serverPaginationData?.currentPage || 0}
- pageSize={
- hasServerPageLengthChanged
- ? serverPageLength
- : serverPaginationData?.pageSize || 10
- }
+ pageSize={serverPaginationData?.pageSize ?? serverPageLength}
Review Comment:
We cannot remove the older code of hasServerPageLength Changed as it causes
a discrepancy between the page length selected from the control panel and the
one from the Page Size Selector
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
