alex-poor commented on code in PR #37109:
URL: https://github.com/apache/superset/pull/37109#discussion_r2724780644
##########
superset-frontend/src/components/Chart/DrillDetail/DrillDetailModal.tsx:
##########
@@ -65,6 +76,43 @@ const ModalFooter = ({
{t('Edit chart')}
</Button>
)}
+ {canDownload && (
+ <Dropdown
+ trigger={['click']}
+ menu={{
+ onClick: ({ key }) => {
+ if (key === 'csv') {
+ onDownloadCSV();
+ } else if (key === 'xlsx') {
+ onDownloadXLSX();
+ }
+ },
+ items: [
+ {
+ key: 'csv',
+ label: t('Export to CSV'),
+ icon: <Icons.FileOutlined />,
+ },
+ {
+ key: 'xlsx',
+ label: t('Export to Excel'),
+ icon: <Icons.FileOutlined />,
+ },
+ ],
+ }}
+ >
+ <Button
+ buttonStyle="secondary"
+ buttonSize="small"
+ css={css`
+ margin-left: ${theme.sizeUnit * 2}px;
+ `}
+ data-test="drill-detail-download-btn"
+ >
+ {t('Download')} <Icons.DownOutlined />
+ </Button>
+ </Dropdown>
+ )}
Review Comment:
This is intentional - keeping "Close" as the primary action (rightmost)
follows standard modal UX patterns where the safe/exit action is primary and
prominent. The download functionality is secondary/optional, so it's
appropriately placed to the left.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
