rusackas commented on PR #37437: URL: https://github.com/apache/superset/pull/37437#issuecomment-3800729674
This dependency update requires additional work: **Issue**: This PR bumps `@storybook/addon-links` from 8.6.14 to 10.2.0 (a major version jump), but all other Storybook packages remain on 8.6.14. This creates a peer dependency conflict: ``` @storybook/[email protected] requires storybook@^10.2.0 as a peer dependency But the project uses Storybook 8.6.14 ``` **Required work**: To properly fix this, we would need to: 1. Update ALL `@storybook/*` packages from 8.6.14 to 10.x across both root `package.json` and `packages/superset-ui-demo/package.json` 2. Review breaking changes between Storybook 8.x → 9.x → 10.x 3. Update Storybook configuration files if needed 4. Test all Storybook functionality This is a coordinated major version upgrade that goes beyond a simple dependency bump. **Recommendation**: Either: - Close this PR and wait for Dependabot to create a comprehensive PR updating all Storybook packages together - Manually coordinate the full Storybook 10.x upgrade across all packages Labeling for manual attention. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
