bito-code-review[bot] commented on code in PR #37454:
URL: https://github.com/apache/superset/pull/37454#discussion_r2729300846
##########
superset-frontend/src/explore/components/controls/ColumnConfigControl/constants.tsx:
##########
@@ -58,6 +58,7 @@ const d3NumberFormat: ControlFormItemSpec<'Select'> = {
creatable: true,
minWidth: '14em',
debounceDelay: 500,
+ tokenSeparators: ['\r\n', '\n', '\t', ';'],
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Inappropriate tokenSeparators for single select</b></div>
<div id="fix">
The tokenSeparators property enables pasting multi-line text into this
single-value select control, which can result in invalid D3 format strings
containing newlines. Since the control expects a single string value and
tokenSeparators are intended for multi-select scenarios, this should be removed
to avoid potential incorrect input.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
- minWidth: '14em',
- debounceDelay: 500,
- tokenSeparators: ['\\r\\n', '\\n', '\\t', ';'],
- };
+ minWidth: '14em',
+ debounceDelay: 500,
+ };
```
</div>
</details>
</div>
<small><i>Code Review Run #5daef7</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
