VanessaGiannoni opened a new pull request, #37456: URL: https://github.com/apache/superset/pull/37456
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Fixed incorrect spacing in the control panel when the Advanced Analytics section is hidden for non-temporal x-axis charts. Root cause: The `displayTimeRelatedControls` visibility function correctly determined when to hide Advanced Analytics for non-temporal x-axis, but the section rendering used `visibility: hidden` instead of `display: none`, leaving empty space in the UI. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> 1. Create or edit a chart with a non-temporal x-axis (e.g., categorical data) 2. Open the chart in Explore view 3. Verify the Advanced Analytics section is not visible in the control panel 4. Confirm there is no extra spacing gap where the section would normally appear 5. Switch to a chart with temporal x-axis and verify Advanced Analytics section appears normally 6. Run the existing tests: ```bash npm run test -- --testPathPatterns="ControlPanelsContainer.test.tsx"``` ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
