codeant-ai-for-open-source[bot] commented on code in PR #37451:
URL: https://github.com/apache/superset/pull/37451#discussion_r2729704652
##########
.rat-excludes:
##########
@@ -71,6 +71,7 @@ temporary_superset_ui/*
google-big-query.svg
google-sheets.svg
ibm-db2.svg
+netlify.png
Review Comment:
**Suggestion:** The exclude pattern uses `netlify.png`, but the PR
description and docs changes introduce a `netlify.svg` logo, so the actual
Netlify logo file will not be excluded from Apache RAT checks and will
incorrectly be flagged for missing license headers. [logic error]
<details>
<summary><b>Severity Level:</b> Critical 🚨</summary>
```mdx
- ❌ CI license check may fail blocking merges.
- ⚠️ Docs PRs with Netlify logo will be flagged.
- ⚠️ CI job output will contain false positives.
```
</details>
```suggestion
netlify.svg
```
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. Inspect repository files: `.rat-excludes` contains "netlify.png" at
`.rat-excludes:74`
(verified via Read of `/workspace/repo_clone/.rat-excludes` lines 72-76).
2. Confirm the docs changes reference an SVG Netlify logo: Grep found
`docs/docusaurus.config.ts` and
`docs/i18n/en/docusaurus-theme-classic/footer.json` in the
repo (files reported by Grep output), indicating the PR adds/uses
`netlify.svg` for the
footer logos.
3. Run Apache RAT/license check (the CI job that consumes `.rat-excludes`)
against the
repository (this is what CI does when linting docs assets). Because
`.rat-excludes` lists
`netlify.png` (not `netlify.svg`), the actual file `netlify.svg` under
`docs/static/img/`
will not match the exclude and will be scanned.
4. Observe Apache RAT reports `docs/static/img/netlify.svg` as an unapproved
third‑party
file / missing license header, causing the license check to fail in CI.
5. Fix: change the entry in `.rat-excludes` from `netlify.png` to
`netlify.svg` so RAT
ignores the actual file (`.rat-excludes` line 74).
```
</details>
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** .rat-excludes
**Line:** 74:74
**Comment:**
*Logic Error: The exclude pattern uses `netlify.png`, but the PR
description and docs changes introduce a `netlify.svg` logo, so the actual
Netlify logo file will not be excluded from Apache RAT checks and will
incorrectly be flagged for missing license headers.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
```
</details>
##########
docs/docusaurus.config.ts:
##########
@@ -473,8 +473,10 @@ const config: Config = {
footer: {
links: [],
copyright: `
- <div class="footer__applitools">
- We use <a href="https://applitools.com/"; target="_blank"
rel="nofollow"><img src="/img/applitools.png" title="Applitools" /></a>
+ <div class="footer__ci-services">
+ <span>CI powered by</span>
+ <a href="https://applitools.com/"; target="_blank" rel="nofollow
noopener noreferrer"><img src="/img/applitools.png" alt="Applitools"
title="Applitools - Visual Testing" /></a>
+ <a href="https://www.netlify.com/"; target="_blank" rel="nofollow
noopener noreferrer"><img src="/img/netlify.png" alt="Netlify" title="Netlify -
Deploy Previews" /></a>
Review Comment:
**Suggestion:** The footer HTML points the Netlify logo image to
`/img/netlify.png`, but the docs static asset added in this PR is `netlify.svg`
(and there is no `netlify.png` under `docs/static/img`), so the logo will 404
and render as a broken image; update the `src` to the correct `.svg` path that
Docusaurus serves from `docs/static`. [logic error]
<details>
<summary><b>Severity Level:</b> Critical 🚨</summary>
```mdx
- ❌ Footer logo image broken on all documentation pages.
- ⚠️ Visual clue for Netlify missing from docs footer.
- ⚠️ Minor UX degradation for site visitors.
- ⚠️ Translation JSON references inconsistent with assets.
```
</details>
```suggestion
<a href="https://www.netlify.com/"; target="_blank" rel="nofollow
noopener noreferrer"><img src="/img/netlify.svg" alt="Netlify" title="Netlify -
Deploy Previews" /></a>
```
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. Confirm references in source: run a repo search (verified with Grep)
which shows the
PNG reference in docs/docusaurus.config.ts at the footer block
(`docs/docusaurus.config.ts:479`) and another reference in
`docs/i18n/en/docusaurus-theme-classic/footer.json` (search results returned
by Grep).
2. Verify static assets present: search for netlify assets in the repo
(verified with
Grep) — there are no matches for `netlify.svg` anywhere in the repository
workspace. Grep
returned "No matches found for pattern 'netlify.svg'".
3. Build or serve the docs locally (standard Docusaurus dev server): the
footer HTML (from
`docs/docusaurus.config.ts` line 476-480) will include an <img
src="/img/netlify.png">
tag.
4. In the browser, navigate to any docs page and open DevTools → Network.
The browser will
request `/img/netlify.png` and receive a 404 because no
`/docs/static/img/netlify.png`
exists in the built site. (Evidence: source contains PNG reference but Grep
shows no
svg/png asset present.)
5. Expected fix: update the src to the actual asset filename that exists in
`docs/static/img` (if the asset is `netlify.svg`) or add the `netlify.png`
file. The
suggested change replaces `.png` with `.svg` so the image resolves if
`netlify.svg` is
present.
```
</details>
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** docs/docusaurus.config.ts
**Line:** 479:479
**Comment:**
*Logic Error: The footer HTML points the Netlify logo image to
`/img/netlify.png`, but the docs static asset added in this PR is `netlify.svg`
(and there is no `netlify.png` under `docs/static/img`), so the logo will 404
and render as a broken image; update the `src` to the correct `.svg` path that
Docusaurus serves from `docs/static`.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
