bito-code-review[bot] commented on code in PR #37441:
URL: https://github.com/apache/superset/pull/37441#discussion_r2730574921
##########
superset-frontend/packages/superset-ui-core/test/time-comparison/parseDttmToDate.test.ts:
##########
@@ -603,7 +603,7 @@ test('should return the date for "2024-03" with
parts.length === 2', () => {
'2024-03',
NOW_UTC_IN_EUROPE,
'Etc/GMT-2',
- new Date('2024-02-29T22:00:00.000Z'),
+ new Date('2024-02-28T22:00:00.000Z'),
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Incorrect leap year test expectation</b></div>
<div id="fix">
Changing the expected date from Feb 29 to Feb 28 for '2024-03' with
Etc/GMT-2 is incorrect, as 2024 is a leap year with 29 days in February. This
could cause tests to pass with wrong expectations, masking bugs in date parsing.
</div>
</div>
<small><i>Code Review Run #f16f7c</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
