semohr commented on code in PR #37396:
URL: https://github.com/apache/superset/pull/37396#discussion_r2731357895
##########
superset-frontend/src/explore/components/DataTablesPane/components/SamplesPane.tsx:
##########
@@ -54,6 +54,7 @@ export const SamplesPane = ({
const [filterText, setFilterText] = useState('');
const [data, setData] = useState<Record<string, any>[][]>([]);
const [colnames, setColnames] = useState<string[]>([]);
+ const [collabels, setCollabels] = useState<string[]>([]);
Review Comment:
Sure, I think I had it like that before. If you want I can make it optional
again. It is however not used like that atm.
Not sure if one can use a newer frontend version with older backend, if this
is possible we should definitely make it optional.
I'm missing some more insights in superset to evaluate this properly. How
does this work in general in superset? How is deprecations and compatibility
handled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
