michael-s-molina commented on PR #37298: URL: https://github.com/apache/superset/pull/37298#issuecomment-3804860331
Nice. Thanks for the updated design @justinpark. Some final suggestions: - Can we move the toolbar to the left to match other panels? - Collapse is pretty clear but what's the behavior of expand? I'm asking because we lazy load the tables and we should not give the option to expand all at once. Maybe remove expand and keep only collapse? - Maybe the minus sign icon (similar to VSCode) is a better icon for the collapse? The current one gives me the impression that I can create a folder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
