semohr commented on PR #37140: URL: https://github.com/apache/superset/pull/37140#issuecomment-3810547534
Just noticed the new `columnDisplayNames` prop. I'm trying to understand the design decision behind this approach, as I'm concerned it might introduce some maintainability challenges. Since `ResultsPane` already receives `colnames` directly from the backend query response, requiring an external `columnDisplayNames` prop creates two separate sources of truth for what is essentially the same data. Without explicit synchronization logic, this seems like it could easily lead to subtle display bugs down the line. I'm also concerned about the prop drilling that this introduces, having to pass display labels through multiple layers feels like it adds complexity without clear benefit. Would it be cleaner to have the backend include display labels as part of the query response? This would keep the component more self-contained and eliminate the risk of data mismatches entirely. I'd appreciate understanding the reasoning behind this approach, as I'm still getting up to speed with this part of the codebase and have just seen the PR merged while trying to resolve conflicts in #37396. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
