michael-s-molina commented on code in PR #37499:
URL: https://github.com/apache/superset/pull/37499#discussion_r2737506604
##########
superset-frontend/packages/superset-core/src/api/contributions.ts:
##########
@@ -74,7 +74,34 @@ export interface ViewContribution {
}
/**
- * Aggregates all contributions (commands, menus, and views) provided by an
extension or module.
+ * Describes an editor that can be contributed to the application.
+ * Extensions declare editor contributions in their extension.json manifest.
+ */
+export interface EditorContribution {
+ /** Unique identifier for the editor (e.g., "acme.monaco-sql") */
+ id: string;
+ /** Display name of the editor */
+ name: string;
+ /** Languages this editor supports */
+ languages: EditorLanguage[];
+ /** Optional description of the editor */
+ description?: string;
+}
+
+/**
+ * Supported editor languages.
+ */
+export type EditorLanguage =
+ | 'sql'
+ | 'json'
+ | 'yaml'
+ | 'markdown'
+ | 'css'
+ | 'html'
+ | 'javascript';
Review Comment:
It's an interesting an idea but it would mean making Ant Design components
implement the same editor interface which I'm not sure if it's currently
possible. It's something we can explore in the future but out of scope for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
