YuriyKrasilnikov commented on PR #37371: URL: https://github.com/apache/superset/pull/37371#issuecomment-3814023409
## Response to codeant-ai bot suggestions Both suggestions are **incorrect** per Superset's type system (see [previous analysis](https://github.com/apache/superset/pull/37371#issuecomment-3791086817)). ### 1. `{"column": "string"}` format Does not exist. `AdhocMetric.column` is `AdhocMetricColumn` (dict) or `None`, never a plain string. Test at line 1360-1375 explicitly documents this as INVALID. ### 2. `tuple` as outer orderby container Also incorrect. Type is `list[OrderBy]` ([superset_typing.py:127](https://github.com/apache/superset/blob/master/superset/superset_typing.py#L127)), schema is `fields.List` ([schemas.py:1345](https://github.com/apache/superset/blob/master/superset/charts/schemas.py#L1345)). The outer container is always `list`, not `tuple`. `tuple` is the **inner** element (`OrderBy = tuple[Metric | Column, bool]`). No changes needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
