Antonio-RiveroMartnez commented on code in PR #37537:
URL: https://github.com/apache/superset/pull/37537#discussion_r2740319074
##########
superset-frontend/src/features/home/RightMenu.tsx:
##########
@@ -489,15 +494,17 @@ const RightMenu = ({
),
});
}
- userItems.push({
- key: 'logout',
- label: (
- <Typography.Link href={navbarRight.user_logout_url}>
- {t('Logout')}
- </Typography.Link>
- ),
- onClick: handleLogout,
- });
+ if (!isFeatureEnabled(FeatureFlag.DisableEmbeddedSupersetLogout)) {
Review Comment:
Isn't more aligned with our existing patterns to use a permission for
hide/show a menu? Was there any reason why that wouldn't work on embedded envs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
