bito-code-review[bot] commented on code in PR #36993:
URL: https://github.com/apache/superset/pull/36993#discussion_r2741664771
##########
superset-frontend/packages/superset-ui-chart-controls/src/sections/chartTitle.tsx:
##########
@@ -23,7 +23,7 @@ import { ControlPanelSectionConfig } from '../types';
import { formatSelectOptions } from '../utils';
export const TITLE_MARGIN_OPTIONS: number[] = [
- 15, 30, 50, 75, 100, 125, 150, 200,
+ 0, 15, 30, 50, 75, 100, 125, 150, 200,
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Shared constant index shift affects defaults</b></div>
<div id="fix">
Adding 0 to the start of TITLE_MARGIN_OPTIONS shifts all indices, changing
default margins for Bubble chart (y-axis from 30 to 15) and Bar chart (x-axis
from 15 to 0, y-axis from 30 to 15). Since this shared constant is imported by
other plugins, verify if these behavioral changes are intended or update the
affected defaults.
</div>
</div>
<small><i>Code Review Run #161e41</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
