codecov-io commented on issue #7912: [sqllab] Fix limit parsing bug when using limit-offset comma notation URL: https://github.com/apache/incubator-superset/pull/7912#issuecomment-514355286 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7912?src=pr&el=h1) Report > Merging [#7912](https://codecov.io/gh/apache/incubator-superset/pull/7912?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2221445f442cacfdfef8186496a5706be09f11ae?src=pr&el=desc) will **decrease** coverage by `7.76%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/7912?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #7912 +/- ## ========================================== - Coverage 73.67% 65.91% -7.77% ========================================== Files 111 465 +354 Lines 11695 22257 +10562 Branches 0 2425 +2425 ========================================== + Hits 8616 14670 +6054 - Misses 3079 7466 +4387 - Partials 0 121 +121 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/7912?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/7912/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.2% <100%> (ø)` | :arrow_up: | | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/7912/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.2% <0%> (ø)` | :arrow_up: | | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/7912/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.77% <0%> (ø)` | :arrow_up: | | [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7912/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | `100% <0%> (ø)` | | | [...ations/deckgl/layers/Polygon/PolygonChartPlugin.js](https://codecov.io/gh/apache/incubator-superset/pull/7912/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbkNoYXJ0UGx1Z2luLmpz) | `0% <0%> (ø)` | | | [...ets/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7912/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9kbmQvRHJhZ0Ryb3BwYWJsZS5qc3g=) | `94.59% <0%> (ø)` | | | [...c/visualizations/deckgl/layers/Polygon/Polygon.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7912/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbi5qc3g=) | `0% <0%> (ø)` | | | [superset/assets/src/components/EditableTitle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7912/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0VkaXRhYmxlVGl0bGUuanN4) | `81.53% <0%> (ø)` | | | [superset/assets/src/setup/setupPlugins.js](https://codecov.io/gh/apache/incubator-superset/pull/7912/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9zZXR1cC9zZXR1cFBsdWdpbnMuanM=) | `0% <0%> (ø)` | | | [...t/assets/src/components/InfoTooltipWithTrigger.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7912/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0luZm9Ub29sdGlwV2l0aFRyaWdnZXIuanN4) | `41.66% <0%> (ø)` | | | ... and [352 more](https://codecov.io/gh/apache/incubator-superset/pull/7912/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7912?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7912?src=pr&el=footer). Last update [2221445...4ad9ae1](https://codecov.io/gh/apache/incubator-superset/pull/7912?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
