LuisSanchez commented on code in PR #37532:
URL: https://github.com/apache/superset/pull/37532#discussion_r2746234360
##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Bar/controlPanel.tsx:
##########
@@ -325,7 +330,22 @@ const config: ControlPanelConfig = {
...seriesOrderSection,
['color_scheme'],
['time_shift_color'],
- ...showValueSection,
+ [showValueControl],
Review Comment:
Yes, exactly, because in this PR we basically create `stackControl` with the
struct in
`superset-frontend/plugins/plugin-chart-echarts/src/controls.tsx::139`.
What I can do is create this structure in `controls.tsx` and use it here,
let's say something like:
``` javascript
import { BarChartStackControlOptions } from './constants';
.
.
export const barStackControl: ControlSetItem = {
...stackControl,
config: {
...stackControl.config,
choices: BarChartStackControlOptions,
},
};
.
.
export const showValueSectionWithoutStream: ControlSetRow[] = [
[showValueControl],
[barStackControl],
[onlyTotalControl],
[percentageThresholdControl],
];
```
Then here just call
```javascript
...showValueSectionWithoutStream,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
