JCelento commented on code in PR #37522:
URL: https://github.com/apache/superset/pull/37522#discussion_r2746370864
##########
superset-frontend/plugins/plugin-chart-echarts/test/MixedTimeseries/transformProps.test.ts:
##########
@@ -28,6 +36,95 @@ import {
EchartsMixedTimeseriesFormData,
EchartsMixedTimeseriesProps,
} from '../../src/MixedTimeseries/types';
+import { DEFAULT_FORM_DATA } from '../../src/MixedTimeseries/types';
+import type { SeriesOption } from 'echarts';
+
+/**
+ * Creates a partial ChartDataResponseResult for testing.
+ * Only includes the fields needed for tests, with sensible defaults for
required fields.
+ */
+function createTestQueryData(
+ data: unknown[],
+ overrides?: Partial<ChartDataResponseResult> & {
+ label_map?: Record<string, string[]>;
+ },
+): ChartDataResponseResult {
+ return {
+ annotation_data: null,
+ cache_key: null,
+ cache_timeout: null,
+ cached_dttm: null,
+ queried_dttm: null,
+ data: data as DataRecord[],
+ colnames: [],
+ coltypes: [],
+ error: null,
+ is_cached: false,
+ query: '',
+ rowcount: data.length,
+ sql_rowcount: data.length,
+ stacktrace: null,
+ status: 'success',
+ from_dttm: null,
+ to_dttm: null,
+ label_map: {},
+ ...overrides,
+ } as ChartDataResponseResult & { label_map?: Record<string, string[]> };
+}
+
+/**
+ * Creates a properly typed EchartsMixedTimeseriesProps for testing.
+ * Merges partial formData with DEFAULT_FORM_DATA to ensure all required
fields are present.
+ */
+function createTestChartProps(config: {
Review Comment:
I have extracted a helper function from it. Could you pls take another look?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
