EnxDev commented on PR #37412: URL: https://github.com/apache/superset/pull/37412#issuecomment-3828884885
> > Hi @reynoldmorel thanks for this contribution! I think it would be good to align with PR #37396, as we may be adding logic that isn’t necessary if the data comes directly from the backend. Feel free to reference PRs #37396 and #37461 to keep patterns consistent, and please ensure the tests follow our best practices > > > > Sure, since any changes could happen at any point, I will wait for the merge to update the implementation. Also, regarding the best practices, would be good to specify what changes need to be done. Sorry, I've put the link with the best practice in your other PR https://github.com/apache/superset/pull/37229#discussion_r2746478053 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
