bito-code-review[bot] commented on code in PR #37229: URL: https://github.com/apache/superset/pull/37229#discussion_r2750135781
########## superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/transformProps.test.ts: ########## @@ -0,0 +1,64 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import transformProps from './transformProps'; +import { mockedMixedTimeSeriesProps } from 'spec/fixtures/mockTimeSeries'; + +test('MixedTimeseries should transform props correctly', () => { + const result = transformProps(mockedMixedTimeSeriesProps); + + expect(result.coltypeMapping).toEqual({ + 'SUM(money_for_learning)': 0, + 'SUM(money_for_learning), 1 day ago': 0, + 'SUM(money_for_learning), 1 week ago': 0, + 'SUM(money_for_learning), 1 year ago': 1, + testing_count: 0, + 'testing_count, 1 day ago': 0, + 'testing_count, 1 week ago': 0, + 'testing_count, 1 year ago': 1, + time_start: 2, + }); + + const legendData = (result.echartOptions.legend as { data: string[] }).data; + + const expectedResult = [ + 'SUM(money_for_learning)', + 'SUM(money_for_learning)', + 'SUM(money_for_learning), 1 day ago', + 'SUM(money_for_learning), 1 day ago', + 'SUM(money_for_learning), 1 week ago', + 'SUM(money_for_learning), 1 week ago', + 'SUM(money_for_learning), 1 year ago', + 'SUM(money_for_learning), 1 year ago', + 'Testing count', + 'Testing count', + 'Testing count, 1 day ago', + 'Testing count, 1 day ago', + 'Testing count, 1 week ago', + 'Testing count, 1 week ago', + 'Testing count, 1 year ago', + 'Testing count, 1 year ago', + 'time_start', + 'time_start', + ]; Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Incorrect test expectations</b></div> <div id="fix"> The test's expectedResult for legendData does not match the actual output from transformProps. The function produces series names like 'testing_count' and 'testing_count, 1 day ago', but the test expects 'Testing count' and 'Testing count, 1 day ago'. Also, 'time_start' is not part of the legend data. </div> </div> <small><i>Code Review Run #a93843</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them ########## superset-frontend/spec/fixtures/mockTimeSeries.ts: ########## @@ -0,0 +1,251 @@ +import { DatasourceType } from '@superset-ui/core'; Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Missing License Header</b></div> <div id="fix"> New files must include the Apache license header. Add the standard ASF header block comment at the beginning of the file. </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ``` @@ -1,0 +1,17 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + ``` </div> </details> </div> <details> <summary><b>Citations</b></summary> <ul> <li> Rule Violated: <a href="https://github.com/apache/superset/blob/a676edb/AGENTS.md#L47";>AGENTS.md:47</a> </li> <li> Rule Violated: <a href="https://github.com/apache/superset/blob/a676edb/.cursor/rules/dev-standard.mdc#L47";>dev-standard.mdc:47</a> </li> </ul> </details> <small><i>Code Review Run #a93843</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
