bito-code-review[bot] commented on code in PR #36071:
URL: https://github.com/apache/superset/pull/36071#discussion_r2754772848
##########
tests/integration_tests/dashboards/api_tests.py:
##########
@@ -81,6 +81,7 @@ class TestDashboardApi(ApiOwnersTestCaseMixin,
InsertChartMixin, SupersetTestCas
dashboard_data = {
"dashboard_title": "title1_changed",
"slug": "slug1_changed",
+ "description": "desc_changed",
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing Test Assertion</b></div>
<div id="fix">
The test_update_dashboard method includes description in the update data but
lacks an assertion to confirm the description field is correctly updated in the
database. This could allow bugs in dashboard description updates to pass
undetected.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
- assert model.slug == self.dashboard_data["slug"]
+ assert model.slug == self.dashboard_data["slug"]
+ assert model.description == self.dashboard_data["description"]
```
</div>
</details>
</div>
<small><i>Code Review Run #1f7a61</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
