andy-clapson opened a new pull request, #37614: URL: https://github.com/apache/superset/pull/37614
…TypeError in results handler The data preview tab in SQL Lab was spinning forever on large tables due to two compounding bugs: 1. `runTablePreviewQuery` never set `queryLimit` on the query payload, so the backend fell back to `SQL_MAX_ROW` (default 100,000) instead of the intended 100-row preview limit. This caused `LIMIT 100001` on the actual DB query. 2. When the oversized result failed to persist in the results backend, the error handler in `SqlExecutionResultsCommand.validate()` crashed with a TypeError attempting to subtract a `decimal.Decimal` (from the SQLAlchemy Numeric column) from a `float`, masking the 410 error as a 500 and leaving the frontend spinner running indefinitely. <!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
