andy-clapson commented on issue #37612: URL: https://github.com/apache/superset/issues/37612#issuecomment-3836265628
> You’re right to double-check—this bug was present, but it was fixed in a recent PR. The subtraction between a float and a decimal.Decimal in the results error handler (SqlExecutionResultsCommand.validate) caused the TypeError you described. This was addressed in [PR #37614](https://github.com/apache/superset/pull/37614), which specifically fixes the crash by handling the type conversion, so the error handler now works as intended and returns the correct 410 error instead of a 500. If you’re still seeing the problematic code or behavior, make sure you’re on a commit after that PR was merged. > > You can see the details and the fix in the PR description and code diff: [PR #37614 – Fixes Decimal TypeError in results handler](https://github.com/apache/superset/pull/37614) > > _To reply, just mention [@dosu](https://go.dosu.dev/dosubot)._ > > How did I do? [Good](https://app.dosu.dev/response-feedback/a698d7cd-0635-437f-a19c-e2a770c84dd5?feedback_type=great_response) | [Irrelevant](https://app.dosu.dev/response-feedback/a698d7cd-0635-437f-a19c-e2a770c84dd5?feedback_type=irrelevant_answer) | [Incorrect](https://app.dosu.dev/response-feedback/a698d7cd-0635-437f-a19c-e2a770c84dd5?feedback_type=incorrect_sources) | [Verbose](https://app.dosu.dev/response-feedback/a698d7cd-0635-437f-a19c-e2a770c84dd5?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/a698d7cd-0635-437f-a19c-e2a770c84dd5?feedback_type=hallucination) | [Report 🐛](https://app.dosu.dev/response-feedback/a698d7cd-0635-437f-a19c-e2a770c84dd5?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/a698d7cd-0635-437f-a19c-e2a770c84dd5?feedback_type=other) > > [](https://app.dosu.dev/a28d3c7e-a9d3-459e-9fb6-3a6f9ff4f357/ask?utm_source=github) [](https://cursor.com/link/prompt?text=You%E2%80%99re%20right%20to%20double-check%E2%80%94this%20bug%20was%20present%2C%20but%20it%20was%20fixed%20in%20a%20recent%20PR.%20The%20subtraction%20between%20a%20float%20and%20a%20decimal.Decimal%20in%20the%20results%20error%20handler%20%28SqlExecutionResultsCommand.validate%29%20caused%20the%20TypeError%20you%20described.%20This%20was%20addressed%20in%20%5BPR%20%2337614%5D%28https%3A//github.com/apache/superset/pull/37614%29%2C%20which%20specifically%20fixes%20the%20crash%20by%20h andling%20the%20type%20conversion%2C%20so%20the%20error%20handler%20now%20works%20as%20intended%20and%20returns%20the%20correct%20410%20error%20instead%20of%20a%20500.%20If%20you%E2%80%99re%20still%20seeing%20the%20problematic%20code%20or%20behavior%2C%20make%20sure%20you%E2%80%99re%20on%20a%20commit%20after%20that%20PR%20was%20merged.%20%0A%0AYou%20can%20see%20the%20details%20and%20the%20fix%20in%20the%20PR%20description%20and%20code%20diff%3A%20%20%0A%5BPR%20%2337614%20%E2%80%93%20Fixes%20Decimal%20TypeError%20in%20results%20handler%5D%28https%3A//github.com/apache/superset/pull/37614%29) [](https://go.dosu.dev/discord-bot) [](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/apache/superset/issues/37612) lol @dosu that is MY Pr that fixes both these bugs. I think you are getting confused a bit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
