Arunodoy18 opened a new pull request, #37616: URL: https://github.com/apache/superset/pull/37616
… auto-detection Root Cause: SSH tunnel creation hardcoded RSAKey.from_private_key(), preventing Ed25519 and other modern key types from working despite Paramiko support. Solution: Replace hardcoded RSA loading with _load_private_key() method that tries all Paramiko-supported key classes (RSA, Ed25519, ECDSA, DSS) in sequence. Key Design Decisions: - Auto-detection via iteration, no hardcoded branching - Preserves exact auth flow and security validation - Returns on first successful load, fails only if all types fail - Order prioritizes common usage (RSA first, modern formats second) Testing: - RSA key loading (backward compatibility verified) - Ed25519 key loading (new capability) - ECDSA and DSS key loading - Encrypted key support with passwords - Invalid key rejection with clear error messages - Empty/malformed key handling Security: - No weakened validation - same Paramiko key loading methods - Failed attempts continue to next type (no info leakage) - Clear error messages on complete failure - Password support preserved for encrypted keys Compatibility: - Fully backward compatible with existing RSA tunnels - No config format changes - No database model changes - Works across all DB tunnel flows <!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
