codeant-ai-for-open-source[bot] commented on PR #37576:
URL: https://github.com/apache/superset/pull/37576#issuecomment-3837136433
## **Sequence Diagram**
The PR fixes a regression by using the ORM column attribute table.id (not
table.data["id"]) when resolving row-level filters during dashboard
serialization. This prevents triggering datasource properties that create a DB
engine, so dashboard loads and chart-level errors are preserved even if the
external DB is unreachable.
```mermaid
sequenceDiagram
participant Client
participant API
participant Serializer
participant SecurityManager
Client->>API: GET /api/v1/dashboard/{id}
API->>Serializer: serialize/dashboard.dump()
Serializer->>SecurityManager: get_rls_filters(table.id) // use table.id
(no .data)
SecurityManager-->>Serializer: row-level filters
Serializer-->>API: serialized dashboard (with per-chart errors)
API-->>Client: 200 OK (dashboard payload)
```
---
*Generated by [CodeAnt AI](https://codeant.ai)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
