rusackas opened a new pull request, #37619:
URL: https://github.com/apache/superset/pull/37619

   ### SUMMARY
   
   The deck.gl plugin dependencies were bumped to `~9.2.5`/`~9.2.6` by 
Dependabot across several PRs, but the root `package.json` overrides section 
was never updated to match — it still pinned all `@deck.gl/*` and `@luma.gl/*` 
packages to `~9.2.2`.
   
   This caused **WebGL shader compilation errors** at runtime on the deck.gl 
Demo dashboard:
   - `DECKGL_FILTER_COLOR: no matching overloaded function found` in 
ScreenGrid, Grid, and Hexagon layers
   - `geometry: undeclared identifier` in the screen-grid fragment shader
   
   **Root cause:** The overrides forced older `@luma.gl/shadertools` (9.2.2) to 
be used alongside newer `@deck.gl/aggregation-layers` (9.2.5). The aggregation 
layers' GPU shaders emit `DECKGL_FILTER_COLOR` calls with a signature that 
changed between 9.2.2 and 9.2.5, causing the shader compilation mismatch.
   
   **Fix:** Update all deck.gl/luma.gl overrides in root `package.json` to 
match the versions required by the plugin:
   - `@deck.gl/*` packages: `~9.2.2` → `~9.2.5`
   - `@luma.gl/engine`, `@luma.gl/shadertools`: `~9.2.2` → `~9.2.6`
   - `@luma.gl/core`, `@luma.gl/constants`, `@luma.gl/webgl`: `~9.2.2` → 
`~9.2.6` (ensures single version deduplication to avoid TypeScript `Device` 
type conflicts)
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   **Before:** Deck.gl Screen Grid, Grid, and Hexagon charts show WebGL shader 
compilation errors
   **After:** Charts render correctly
   
   ### TESTING INSTRUCTIONS
   
   1. Open the "deck.gl Demo" dashboard
   2. Verify the **Deck.gl Screen grid**, **Deck.gl Grid**, and **Deck.gl 
Hexagons** charts render without shader errors
   3. Verify all other deck.gl charts (Scatterplot, Arcs, Path, Polygons) still 
work
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to