betodealmeida commented on code in PR #34826: URL: https://github.com/apache/superset/pull/34826#discussion_r2765075590
########## superset/extensions/engine_manager.py: ########## @@ -0,0 +1,100 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import logging +from datetime import timedelta + +from flask import Flask + +from superset.engines.manager import EngineManager, EngineModes + +logger = logging.getLogger(__name__) + + +class EngineManagerExtension: + """ + Flask extension for managing SQLAlchemy engines in Superset. + + This extension creates and configures an EngineManager instance based on + Flask configuration, handling startup and shutdown of background cleanup + threads as needed. + """ + + def __init__(self) -> None: + self.engine_manager: EngineManager | None = None + + def init_app(self, app: Flask) -> None: + """ + Initialize the EngineManager with Flask app configuration. + """ + engine_context_manager = app.config["ENGINE_CONTEXT_MANAGER"] + db_connection_mutator = app.config["DB_CONNECTION_MUTATOR"] + mode = app.config["ENGINE_MANAGER_MODE"] + cleanup_interval = app.config["ENGINE_MANAGER_CLEANUP_INTERVAL"] Review Comment: I updated the comments in `superset/config.py`, we want to use a `timedelta`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
