rusackas commented on code in PR #37625:
URL: https://github.com/apache/superset/pull/37625#discussion_r2766003893
##########
superset-frontend/src/dashboard/components/DashboardGrid.tsx:
##########
@@ -117,22 +130,28 @@ const GridColumnGuide = styled.div`
`};
`;
-class DashboardGrid extends PureComponent {
- constructor(props) {
+class DashboardGrid extends PureComponent<
+ DashboardGridProps,
+ DashboardGridState
+> {
+ grid: HTMLDivElement | null;
+
+ constructor(props: DashboardGridProps) {
super(props);
this.state = {
isResizing: false,
};
- this.theme = this;
+ this.grid = null;
this.handleResizeStart = this.handleResizeStart.bind(this);
+ this.handleResize = this.handleResize.bind(this);
Review Comment:
handleResize is actively passed as onResize={this.handleResize} on line
349. Removing the binding would cause a runtime error. The method is
intentionally a no-op because resize position is tracked elsewhere via
getRowGuidePosition, but it must still exist to satisfy the child component's
callback API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
