EnxDev commented on code in PR #37358:
URL: https://github.com/apache/superset/pull/37358#discussion_r2766290820
##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/ConfigModalSidebar/ConfigModalSidebar.tsx:
##########
@@ -140,6 +142,7 @@ const ConfigModalSidebar: FC<ConfigModalSidebarProps> = ({
/>
</StyledHeaderFlex>
<StyledCollapse
+ key={formValuesVersion}
Review Comment:
Using key={formValuesVersion} on StyledCollapse causes React to fully
unmount and remount the entire collapse tree on every form change (including
each keystroke). This might be a bit heavy-handed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
