rusackas commented on PR #37588: URL: https://github.com/apache/superset/pull/37588#issuecomment-3855664181
Responding to the bot review comments: **1. `onBrokenMarkdownLinks` location (`docusaurus.config.ts`)** — No change needed. The `markdown.hooks.onBrokenMarkdownLinks` placement is correct for Docusaurus 3.9.2. You can verify in the type definition at `@docusaurus/types/src/markdown.d.ts`, where `MarkdownConfig` has a `hooks: MarkdownHooks` property, and `MarkdownHooks` includes `onBrokenMarkdownLinks`. The top-level `onBrokenMarkdownLinks` is the deprecated location. **2. `exclude: /node_modules/` for swc-loader (`webpack.extend.ts`)** — Good catch. Added `exclude: /node_modules/` to prevent re-transpiling third-party dependencies under `superset-frontend/node_modules`. Fixed in the latest commit. **3. Emotion CSS-in-JS without `@swc/plugin-emotion` (`webpack.extend.ts`)** — This works correctly without the SWC Emotion plugin. The config uses `importSource: '@emotion/react'` with `runtime: 'automatic'`, which handles the JSX pragma transform — this is what makes the `css` prop and `styled` API work. The `@swc/plugin-emotion` only adds dev-time niceties (auto-labeling, source maps for CSS-in-JS) and optimizations, none of which are needed for the docs site build. The line `swcrc: false` is intentional to avoid pulling in `@swc/plugin-emotion` which isn't installed in the docs workspace. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
