SBIN2010 commented on code in PR #37581:
URL: https://github.com/apache/superset/pull/37581#discussion_r2771397602
##########
superset-frontend/src/components/ListView/ListView.tsx:
##########
@@ -24,13 +24,14 @@ import TableCollection from
'@superset-ui/core/components/TableCollection';
import BulkTagModal from 'src/features/tags/BulkTagModal';
import {
Button,
+ Tooltip,
Checkbox,
Icons,
EmptyState,
Loading,
- Pagination,
type EmptyStateProps,
} from '@superset-ui/core/components';
+import { Pagination } from 'antd';
Review Comment:
It seems that this change is not necessary.
##########
superset-frontend/src/components/ListView/ListView.tsx:
##########
@@ -201,31 +202,34 @@ const ViewModeToggle = ({
setMode: (mode: 'table' | 'card') => void;
}) => (
<ViewModeContainer>
- <div
- role="button"
- tabIndex={0}
- onClick={e => {
- e.currentTarget.blur();
- setMode('card');
- }}
- className={cx('toggle-button', { active: mode === 'card' })}
- >
- <Icons.AppstoreOutlined iconSize="xl" />
- </div>
- <div
- role="button"
- tabIndex={0}
- onClick={e => {
- e.currentTarget.blur();
- setMode('table');
- }}
- className={cx('toggle-button', { active: mode === 'table' })}
- >
- <Icons.UnorderedListOutlined iconSize="xl" />
- </div>
+ <Tooltip title={t('Grid view')}>
+ <div
+ role="button"
+ tabIndex={0}
+ onClick={e => {
Review Comment:
Please add typing (e: MouseEvent)
##########
superset-frontend/src/components/ListView/ListView.tsx:
##########
@@ -201,31 +202,34 @@ const ViewModeToggle = ({
setMode: (mode: 'table' | 'card') => void;
}) => (
<ViewModeContainer>
- <div
- role="button"
- tabIndex={0}
- onClick={e => {
- e.currentTarget.blur();
- setMode('card');
- }}
- className={cx('toggle-button', { active: mode === 'card' })}
- >
- <Icons.AppstoreOutlined iconSize="xl" />
- </div>
- <div
- role="button"
- tabIndex={0}
- onClick={e => {
- e.currentTarget.blur();
- setMode('table');
- }}
- className={cx('toggle-button', { active: mode === 'table' })}
- >
- <Icons.UnorderedListOutlined iconSize="xl" />
- </div>
+ <Tooltip title={t('Grid view')}>
+ <div
+ role="button"
+ tabIndex={0}
+ onClick={e => {
+ e.currentTarget.blur();
+ setMode('card');
+ }}
+ className={cx('toggle-button', { active: mode === 'card' })}
+ >
+ <Icons.AppstoreOutlined iconSize="xl" />
+ </div>
+ </Tooltip>
+ <Tooltip title={t('List view')}>
+ <div
+ role="button"
+ tabIndex={0}
+ onClick={e => {
Review Comment:
And add here too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
