rusackas commented on PR #34661:
URL: https://github.com/apache/superset/pull/34661#issuecomment-3857283207
## PR Updated - Rebased and Review Feedback Addressed
### Changes Made
1. **Rebased on master** - Resolved merge conflict in package-lock.json
2. **Addressed @michael-s-molina's feedback** - You're correct! The
`StringConstructor` return type is no longer valid since no code path returns
`String` anymore. I've:
- Removed `StringConstructor` from the return type (now `TimeFormatter |
undefined`)
- Updated the misleading test description that mentioned "String
constructor"
### Current Behavior
| Input | Output |
|-------|--------|
| `SMART_DATE_ID` ("smart_date") | Returns `getSmartDateFormatter()` -
respects D3 locale |
| Other format string (e.g., "%Y-%m-%d") | Returns
`getTimeFormatter(format)` - respects D3 locale |
| No format / empty string | Returns `undefined` - ECharts uses its default |
This ensures that when users select "Adaptive" datetime format, the D3
locale settings (like Russian month names) are properly applied.
### Summary of the Fix
The root issue was that `getXAxisFormatter()` was returning `undefined` for
`SMART_DATE_ID`, causing ECharts to use its default (English) formatter instead
of the D3 locale-aware smart date formatter. Now it correctly returns the
locale-respecting formatter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
