rusackas commented on PR #37442: URL: https://github.com/apache/superset/pull/37442#issuecomment-3858277938
Rebased on master and fixed compatibility issues with d3-format v3: **Changes made:** 1. Added `d3-format` to Jest's `transformIgnorePatterns` - d3-format v3 is ESM-only 2. Added `minus: '-'` to `DEFAULT_D3_FORMAT` locale config - d3-format v3 uses Unicode minus sign (−) by default, which would break backward compatibility 3. Updated `createSmartNumberFormatter` and `createSiAtMostNDigitFormatter` to use locale-aware formatting All 74 number-format tests pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
