bito-code-review[bot] commented on code in PR #37745:
URL: https://github.com/apache/superset/pull/37745#discussion_r2772867956
##########
superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/TableRenderers.jsx:
##########
@@ -718,7 +718,9 @@ export class TableRenderer extends Component {
true,
)}
>
- {t('Subtotal')}
+ {t('Subvalue (%(aggregatorName)s)', {
+ aggregatorName: t(this.props.aggregatorName),
+ })}
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing Translation Key</b></div>
<div id="fix">
The new translation key 'Subvalue (%(aggregatorName)s)' isn't in the
translation files, so the UI will show the raw key instead of translated text
for subtotal labels in pivot tables. Also, 'Subvalue' appears to be a typo for
'Subtotal'. Consider updating to 'Subtotal (%(aggregatorName)s)' like the Total
label does, and ensure translations are added.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
- {t('Subvalue (%(aggregatorName)s)', {
+ {t('Subtotal (%(aggregatorName)s)', {
@@ -936,3 +936,3 @@
- {t('Subvalue (%(aggregatorName)s)', {
+ {t('Subtotal (%(aggregatorName)s)', {
```
</div>
</details>
</div>
<small><i>Code Review Run #78dc73</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
