bito-code-review[bot] commented on code in PR #37681:
URL: https://github.com/apache/superset/pull/37681#discussion_r2776671740
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx:
##########
@@ -319,10 +334,38 @@ const FilterBar: FC<FiltersBarProps> = ({
}, [dashboardId, filters, previousDashboardId, setDataMaskSelected]);
const dataMaskAppliedText = JSON.stringify(dataMaskApplied);
+ const prevDataMaskAppliedRef = useRef(dataMaskApplied);
useEffect(() => {
- setDataMaskSelected(() => dataMaskApplied);
- }, [dataMaskAppliedText, setDataMaskSelected, dashboardId]);
+ const dashboardChanged = dashboardId !== previousDashboardId;
+
+ if (dashboardChanged) {
+ setDataMaskSelected(() => dataMaskApplied);
+ } else {
+ const prevApplied = prevDataMaskAppliedRef.current;
+
+ // Only sync filters whose applied state actually changed
+ setDataMaskSelected(prev => {
+ let hasChanges = false;
+ const updated = { ...prev };
+
+ Object.entries(dataMaskApplied).forEach(([filterId, appliedMask]) => {
+ const prevAppliedMask = prevApplied[filterId];
+ const appliedChanged = !isEqual(appliedMask, prevAppliedMask);
+ const notInitialized = !prev[filterId];
+
+ if (appliedChanged || notInitialized) {
+ updated[filterId] = appliedMask;
+ hasChanges = true;
+ }
+ });
+
+ return hasChanges ? updated : prev;
+ });
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Filter State Sync Bug</b></div>
<div id="fix">
Consider extending the sync logic to remove any filters from
`dataMaskSelected` that are no longer present in `dataMaskApplied`, ensuring no
stale filter entries remain.
</div>
</div>
<small><i>Code Review Run #b3a1e2</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
