KH-Coder865 opened a new pull request, #37777:
URL: https://github.com/apache/superset/pull/37777

   ### SUMMARY
   This PR fixes a frontend issue in the **Mixed chart “View as table” modal** 
where multiple result tables remain visible when switching between tabs.
   
   For mixed charts, multiple result panes (Results, Results 2, etc.) are 
rendered, but inactive panes were not being unmounted when the active tab 
changed. This caused previously rendered tables to remain visible and overlap 
in the UI.
   
   The fix conditionally renders each tab’s content based on the active tab 
key, ensuring that only the selected tab’s table is visible at any time.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   **Before:** Switching between result tabs causes multiple tables to remain 
visible simultaneously.  
   **After:** Only the active tab’s table is rendered and visible.
   
   ### TESTING INSTRUCTIONS
   1. Create or open a **Mixed chart** with multiple queries.
   2. Run the chart.
   3. Click **View as table**.
   4. Switch between **Results**, **Results 2**, and **Samples** tabs.
   5. Verify that only the currently selected tab’s table is visible.
   6. Confirm there are no layout or scrolling issues when switching tabs.
   
   ### FIXES
   - Closes #37772 
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### LABELS
   - ```viz:charts:table```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to