codeant-ai-for-open-source[bot] commented on PR #37768:
URL: https://github.com/apache/superset/pull/37768#issuecomment-3869534113
## **Sequence Diagram**
The PR moves shared table-related TypeScript types into
@superset-ui/chart-controls and updates table plugins to re-export them, and
fixes a typo by renaming the Funnel label enum; this shows the high-level code
change and how plugin modules consume the updated types.
```mermaid
sequenceDiagram
participant Dev as Developer (PR)
participant ChartControls as @superset-ui/chart-controls
participant TablePlugins as plugin-chart-table /
plugin-chart-ag-grid-table
participant FunnelModule as plugin-chart-echarts (Funnel)
participant TypeCheck as TypeScript type checker
Dev->>ChartControls: Add shared table types (BasicColorFormatter,
SortByItem, SearchOption, ServerPaginationData, TableColumnConfig,
DataColumnMeta, CustomFormatter)
ChartControls-->>TablePlugins: Expose types for import (new exports)
Dev->>TablePlugins: Update imports to import type from chart-controls
and re-export for local/internal use
Dev->>FunnelModule: Rename EchartsFunnelLabelTypeType ->
EchartsFunnelLabelType and update references in types, transformProps,
controlPanel
TablePlugins->>TypeCheck: Build & type-check using consolidated types
FunnelModule->>TypeCheck: Build & type-check using renamed enum
```
---
*Generated by [CodeAnt AI](https://codeant.ai)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
