msyavuz commented on code in PR #37537:
URL: https://github.com/apache/superset/pull/37537#discussion_r2781522865
##########
superset-frontend/src/features/home/RightMenu.tsx:
##########
@@ -489,15 +494,17 @@ const RightMenu = ({
),
});
}
- userItems.push({
- key: 'logout',
- label: (
- <Typography.Link href={navbarRight.user_logout_url}>
- {t('Logout')}
- </Typography.Link>
- ),
- onClick: handleLogout,
- });
+ if (!isFeatureEnabled(FeatureFlag.DisableEmbeddedSupersetLogout)) {
Review Comment:
This looks like it hides the button when feature flag is not enabled right?
I don't see any checks for figuring out if it's an embedded context. Will this
hide the button if the ff is true even on the non-embedded app?
Also the naming is a bit confusing with multiple negatives.
`! isFeautureEnabled ( DisableEmbeddedSupersetLogout )`
Can we improve the readability somehow?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
