jayvenn21 commented on code in PR #37773:
URL: https://github.com/apache/superset/pull/37773#discussion_r2783035120
##########
superset/security/manager.py:
##########
@@ -3022,6 +3022,24 @@ def register_views(self) -> None:
) in ["/roles", "/users", "/groups", "registrations"]:
self.appbuilder.baseviews.remove(view)
Review Comment:
Yes and that’s exactly what the latest commit does.
I updated the logic to explicitly remove the legacy FAB security views from
`appbuilder.baseviews` when the config flag is disabled, using this iteration
pattern. Also, I added a guard for Flask versions where `unregister_blueprint`
may not be available.
Let me know if you’d prefer a different removal point or if this should live
upstream in FAB instead as I'm happy to adjust.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
