YousufFFFF commented on PR #37712: URL: https://github.com/apache/superset/pull/37712#issuecomment-3873404417
Thanks for the review! As mentioned in the PR description, this change ensures that when a dimension (groupby) is added, the X-Axis Sort By options remain consistent and continue to expose other selected columns. The demo video I shared focuses on the dimension case. You’re right that it doesn’t currently show an example where a column is added via the “Sort By” (Query Sort By) control (e.g. sorting DayName by Day_Number). I can update the video to cover both scenarios: • sorting DayName by Day_Number when a dimension is present • demonstrating a value added via the “Sort By” control appearing in X-Axis Sort By Please let me know if you’d like that additional demo or any further adjustments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
