rusackas commented on PR #37800: URL: https://github.com/apache/superset/pull/37800#issuecomment-3874598112
Via my handy ReviewBot3000: > The pattern is a bit unusual. The component already initializes collapsedFolderIds from folders in useState. The useEffect catches cases where folders is empty/undefined on first render but populated later. This works, but a cleaner pattern might be to derive the initial state differently. I'll approve it, but maybe it needs a second pair of eyes from someone like @msyavuz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
