imad-hl opened a new issue, #37853:
URL: https://github.com/apache/superset/issues/37853

   ### Bug description
   
   After PR #37625 (commit `fc5506e466`), cross-filtering behavior is broken 
across charts:
   
   1. **No visual highlights** when cross-filters are applied
   2. **Right-clicking retriggers chart animations** instead of showing the 
context menu properly
   3. Cross-filter interactions feel broken/unresponsive, and reclicking on 
selected data doesn't undo the cross-filter
   
   ## Reproduction Steps
   
   0. On latest master branch
   1. Create a dashboard with any charts that support cross-filtering
   2. Enable cross-filtering
   3. Click on a data point to apply a cross-filter
   4. Right-click on a data point
   5. Observe the broken behavior
   
   ## Expected Behavior
   
   - Cross-filter should highlight selected data
   - Right-click should open context menu without retriggering animations
   
   ## Actual Behavior
   
   - No visual feedback when cross-filtering is applied
   - Right-clicking causes charts to re-animate
   - Reclicking selected data doesn't toggle off the cross-filter
   
   ## Bisect Results
   
   - ✅ **Working:** commit `e9ae212c1c` (before PR #37625)
   - ❌ **Broken:** commit `fc5506e466` (PR #37625)
   
   See attached GIFs showing the difference.
   
   ### Screenshots/recordings
   
   Before PR :  #37625
   
![Image](https://github.com/user-attachments/assets/63de91f1-da80-4397-9050-a1bda377738d)
   
   After PR :  #37625
   
![Image](https://github.com/user-attachments/assets/0a407045-c488-4421-8a59-8ed9f89060d1)
   
   ### Superset version
   
   master / latest-dev
   
   ### Python version
   
   3.9
   
   ### Node version
   
   16
   
   ### Browser
   
   Chrome
   
   ### Additional context
   
   **Note:** I discovered this issue while working on my PR #35859 to add 
cross-filter support to the Country Map chart. During testing on the latest 
master branch, I noticed cross-filters weren't working as expected across all 
charts, which led me to bisect and identify this regression.
   
   ### Checklist
   
   - [x] I have searched Superset docs and Slack and didn't find a solution to 
my problem.
   - [x] I have searched the GitHub issue tracker and didn't find a similar bug 
report.
   - [x] I have checked Superset's logs for errors and if I found a relevant 
Python stacktrace, I included it here as text in the "additional context" 
section.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to