SBIN2010 commented on code in PR #35897:
URL: https://github.com/apache/superset/pull/35897#discussion_r2790500507
##########
superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx:
##########
@@ -934,18 +939,43 @@ export default function TableChart<D extends DataRecord =
DataRecord>(
formatter.getColorFromValue(valueToFormat);
if (!formatterResult) return;
- if (formatter.toTextColor) {
+ if (
+ formatter.objectFormatting === ObjectFormattingEnum.TEXT_COLOR
+ ) {
color = formatterResult.slice(0, -2);
+ } else if (
+ formatter.objectFormatting === ObjectFormattingEnum.CELL_BAR
+ ) {
+ if (showCellBars)
Review Comment:
Everything is correct here; the color of the bars is set if the showCellBars
flag is enabled.
Also if the ObjectFormattingEnum.CELL_BAR parameter is selected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
